Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to eslint 9 and flat config #2192

Merged
merged 131 commits into from
Nov 28, 2024
Merged

Migrate to eslint 9 and flat config #2192

merged 131 commits into from
Nov 28, 2024
+34,766 −18,326

Conversation

matthieu-crouzet
Copy link
Contributor

@matthieu-crouzet matthieu-crouzet commented Sep 23, 2024 •
edited
Loading

Proposed change

Migrate to eslint 9 and flat config

Missing in this PR:

  • Review with the team the config exposed in @o3r/eslint-config
  • Fix errors due to the new config
  • Documentation:
    • Difference of rules between the 2 configs
    • Update global documentation (docs/linter/*)
  • fix ng-add @o3r/eslint-config
  • fix jsdoc/check-examples
  • Bonus: CLI to detect deprecated rules

@matthieu-crouzet matthieu-crouzet changed the title Migrate to eslint 9 and flat config [DO NOT REVIEW] Migrate to eslint 9 and flat config Sep 23, 2024
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 23, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 71d72f0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 11 targets

Sent with 💌 from NxCloud.

@matthieu-crouzet matthieu-crouzet linked an issue Nov 22, 2024 that may be closed by this pull request
[Feature]: Review and cleanup eslint-config #2052
Closed
@kpanot kpanot mentioned this pull request Nov 25, 2024
Open
1 task
@matthieu-crouzet matthieu-crouzet marked this pull request as ready for review November 28, 2024 09:33
@matthieu-crouzet matthieu-crouzet requested a review from a team as a code owner November 28, 2024 09:33
@matthieu-crouzet matthieu-crouzet changed the title [DO NOT REVIEW] Migrate to eslint 9 and flat config Migrate to eslint 9 and flat config Nov 28, 2024
@matthieu-crouzet matthieu-crouzet added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit 3a6a2d7 Nov 28, 2024
34 of 36 checks passed
@matthieu-crouzet matthieu-crouzet deleted the feat/migrate-eslint-9-flat-config branch November 28, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpaulve-1A cpaulve-1A cpaulve-1A approved these changes

@fpaul-1A fpaul-1A fpaul-1A approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request project:@ama-sdk/core project:@ama-sdk/create project:@ama-sdk/schematics project:@ama-sdk/showcase-sdk project:@ama-sdk/swagger-builder project:@ama-terasu/cli project:@ama-terasu/core project:@ama-terasu/schematics project:audit-gh-action project:cascading-gh-action project:get-npm-tag-gh-action project:new-version-gh-action project:@o3r/amaterasu-api-spec project:@o3r/amaterasu-dodo project:@o3r/amaterasu-otter project:@o3r/amaterasu-sdk project:@o3r/analytics project:@o3r/apis-manager project:@o3r/application project:@o3r/artifactory-tools project:@o3r/azure-tools project:@o3r/build-helpers project:@o3r/chrome-devtools project:@o3r/components project:@o3r/configuration project:@o3r/core project:@o3r/create project:@o3r/design project:@o3r/dev-tools project:@o3r/dynamic-content project:@o3r/eslint-config project:@o3r/eslint-config-otter project:@o3r/eslint-plugin project:@o3r/extractors project:@o3r/forms project:@o3r/github-cascading-app project:@o3r/localization project:@o3r/logger project:@o3r/mobile project:@o3r/new-version project:@o3r/routing project:@o3r/rules-engine project:@o3r/schematics project:@o3r/showcase project:@o3r/store-sync project:@o3r/storybook project:@o3r/stylelint-plugin project:@o3r/styling project:@o3r/telemetry project:@o3r/test-helpers project:@o3r/testing project:@o3r/third-party project:@o3r/workspace project:otter-devtools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Review and cleanup eslint-config
5 participants
@matthieu-crouzet @fpaul-1A @cpaulve-1A @kpanot @sdo-1A